Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Preview pane docs outdated #10878

Closed
Aaron-Junker opened this issue Apr 21, 2021 · 8 comments
Closed

[docs] Preview pane docs outdated #10878

Aaron-Junker opened this issue Apr 21, 2021 · 8 comments
Labels
Issue-Docs Documentation issue that needs to be improved Priority-2 Bug that is medium priority Product-File Explorer Power Toys that touch explorer like Preview Pane

Comments

@Aaron-Junker
Copy link
Collaborator

Aaron-Junker commented Apr 21, 2021

Provide a description of requested docs changes

The docs for the preview pane (https://github.com/microsoft/PowerToys/blob/master/src/modules/previewpane/README.md) are outdated.

I would love to have them up to date next week, because then I could easy implement monaco, because I have many time next week.

We should also move this document into the doc folder.

@Aaron-Junker Aaron-Junker added Issue-Docs Documentation issue that needs to be improved Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 21, 2021
@dedavis6797 dedavis6797 added Product-File Explorer Power Toys that touch explorer like Preview Pane and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 21, 2021
@dedavis6797 dedavis6797 self-assigned this Apr 21, 2021
@crutkas
Copy link
Member

crutkas commented Apr 21, 2021

@Aaron-Junker, been a long time since we last looked at these. what makes these out of date?

I don't think the settings aspect for Monaco will be easy / the installer aspect. #10126 still needs to happen for file associate

@crutkas crutkas added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 21, 2021
@ghost ghost added the Status-No recent activity no activity in the past 5 days when follow up's are needed label Apr 26, 2021
@ghost
Copy link

ghost commented Apr 26, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

@Aaron-Junker
Copy link
Collaborator Author

For example Navigate to the powerpreview project and edit the powerpreview.h file. Add the following Settings Object instance to m_previewHandlers settings objects array in the constructor initialization: There is no way to add a settings object instance to m_previewHandlers Because there is no m_previewHandlers

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Status-No recent activity no activity in the past 5 days when follow up's are needed labels Apr 29, 2021
@enricogior enricogior changed the title Preview pane docs outdated [docs] Preview pane docs outdated May 3, 2021
@Yongjun042
Copy link

Is this in progress now? I'm not sure what is wrong/missing integrating preview.

@crutkas crutkas removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Jun 9, 2021
@dedavis6797 dedavis6797 removed their assignment Jun 16, 2021
@Jay-o-Way
Copy link
Collaborator

Is this still an issue?

@crutkas
Copy link
Member

crutkas commented Nov 30, 2021

These are dev docs so there is a chance.

@crutkas crutkas added this to the Priority work bucket milestone Nov 30, 2021
@crutkas crutkas added the Priority-2 Bug that is medium priority label Nov 30, 2021
@Jay-o-Way
Copy link
Collaborator

<rel>#761, #17951</rel>

@Aaron-Junker
Copy link
Collaborator Author

This seems to be completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Docs Documentation issue that needs to be improved Priority-2 Bug that is medium priority Product-File Explorer Power Toys that touch explorer like Preview Pane
Projects
None yet
Development

No branches or pull requests

5 participants