Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings] Plugin search field: Text and symbol overlap #13080

Closed
htcfreek opened this issue Sep 6, 2021 · 14 comments · Fixed by #15704
Closed

[Settings] Plugin search field: Text and symbol overlap #13080

htcfreek opened this issue Sep 6, 2021 · 14 comments · Fixed by #15704
Assignees
@niels9001
Labels
Area-User Interface things that regard UX for PowerToys External Dependency This bug or feature isn't resolved, but it's following an external work item. Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Resolution-External External issue, unrelated to PowerToys

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Sep 6, 2021

Without cursor focus it looks this:20210906_180220.jpg
@htcfreek
Copy link
Collaborator Author

htcfreek commented Sep 6, 2021 •
edited by niels9001
Loading

cc @niels9001: See microsoft/microsoft-ui-xaml#5537

@niels9001
Copy link
Contributor

Thanks for flagging, seems that this PR will fix it: microsoft/microsoft-ui-xaml#5779

Once this gets merged in we can update the WinUI package so the issue will resolve itself :)!

@niels9001 niels9001 added Product-Settings The standalone PowerToys Settings application Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Status-Blocked We can't make progress due to a dependency or issue External Dependency This bug or feature isn't resolved, but it's following an external work item. labels Sep 6, 2021
@niels9001 niels9001 self-assigned this Sep 6, 2021
@niels9001 niels9001 mentioned this issue Sep 8, 2021
Closed
@htcfreek
Copy link
Collaborator Author

@niels9001
microsoft/microsoft-ui-xaml#5537 is merged. Don't know if it's released.

@htcfreek htcfreek mentioned this issue Jan 10, 2022
Closed
1 task
@htcfreek
Copy link
Collaborator Author

Fixed in Microsoft.UI.Xaml vMicrosoft.Experimental.UI.Xaml.2.8.0-prerelease.220118001!

@niels9001 niels9001 mentioned this issue Jan 22, 2022
Merged
10 tasks
@ghost ghost added the Status-In progress This issue or work-item is under development label Jan 22, 2022
@niels9001 niels9001 removed the Status-Blocked We can't make progress due to a dependency or issue label Jan 22, 2022
@ghost ghost added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jan 25, 2022
@franky920920 franky920920 reopened this Jan 25, 2022
@franky920920
Copy link
Contributor

@niels9001 Please update the project. Thanks!

@jaimecbernardo jaimecbernardo removed the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 25, 2022
@jaimecbernardo jaimecbernardo added the Status-In progress This issue or work-item is under development label Jan 25, 2022
@jaimecbernardo
Copy link
Collaborator

The fix for this issue ended up being reverted in #15138 , due to including the WebView dependencies. A bit more investigation needs to be put here to understand the implications.

@htcfreek
Copy link
Collaborator Author

The fix for this issue ended up being reverted in #15138 , due to including the WebView dependencies. A bit more investigation needs to be put here to understand the implications.

Project in progress 0.56?

@niels9001
Copy link
Contributor

@Jay-o-Way Windows Apps SDK apps (like PT Settings) still use WinUI 2.7 - the bug is fixed in 2.8, once that goes into WAS we can update and we can then close this issue :). I'll mark it as blocked for now.

@niels9001 niels9001 added Status-Blocked We can't make progress due to a dependency or issue and removed Status-In progress This issue or work-item is under development labels May 8, 2022
@Jay-o-Way
Copy link
Collaborator

(like PT Settings) still use WinUI 2.7

Oh, I thought we moved to WinUI3?

@niels9001
Copy link
Contributor

(like PT Settings) still use WinUI 2.7

Oh, I thought we moved to WinUI3?

Gotta love the naming :-).

WinUI3 = app model/framework (that comes with the Windows Apps SDK)
WinUI 2.x = UI component toolkit.

So WinUI 3 (the app model) uses WinUI 2.x components (e.g. UWP or XAML Islands) can use WinUI 2.7 to replace the default components.

tl;dr; WinUI 3 (= Settings) still uses the 2.7 version of the UI components. Once 2.8 is out of prerelease, it will adopt 2.8 which contains the fix for this bug :).

@Jay-o-Way
Copy link
Collaborator

Ah yes that makes sense 😆 Maybe we can move to "pure" WinUI3 without XAML islands and such?

@niels9001
Copy link
Contributor

Ah yes that makes sense 😆 Maybe we can move to "pure" WinUI3 without XAML islands and such?

We did with 0.58. Settings now uses WinUI3 (so no more XAML Islands), which depends on WinUI 2.7 for the control styles. We just need to wait for WinUI 3 to adopt WinUI 2.8 and update the package to get this bug fixed.

@Jay-o-Way
Copy link
Collaborator

Is this still an issue with the latest version? /needinfo I believe not :)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 9, 2023
@htcfreek
Copy link
Collaborator Author

htcfreek commented Feb 9, 2023

no. it is fixed. thanks for reminding.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 9, 2023
@Jay-o-Way Jay-o-Way added Resolution-External External issue, unrelated to PowerToys and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Status-Blocked We can't make progress due to a dependency or issue Needs-Team-Response An issue author responded so the team needs to follow up labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niels9001 niels9001

Labels
Area-User Interface things that regard UX for PowerToys External Dependency This bug or feature isn't resolved, but it's following an external work item. Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Resolution-External External issue, unrelated to PowerToys
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Settings] Nuget packages update microsoft/PowerToys
5 participants
@niels9001 @franky920920 @jaimecbernardo @htcfreek @Jay-o-Way