[AutoSuggestBox] Fix bug where find icon would be placed incorrectly in control #5779
Conversation
ghost
added
the
|
@myokeeh FYI, your repro app definitely helped track this bug down! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@chingucoding FYI on the visual verification files |
|
Updated now, thanks @StephenLPeters |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks like we have verification test failures, however the newly published verification files don't contain any changes. @StephenLPeters @kaiguo Do you have any idea what we could do here (maybe just rerun?)? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-AutoSuggestBox
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I've updated the verification files, however the script does not work as expected; it suggested just flat out deleting two files instead of updating the existing files. Is this just something that happens on my machine or is this worth investigating further? |
|
Did my best guess at fixing the verification file merge conflict by hand but I suspect we'll need to update it again :( |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Updated them again, guess someone really needs to look into why updating the files doesn't work correctly. |
|
Well this time is was because your version conflicted with another change we took before checking this in. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Oh I see, sorry my bad. |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Description
The issue was that the placeholder present was placed in all 4 columns even though it should have only be placed in two columns
Motivation and Context
Closes #5537
How Has This Been Tested?
Tested manually.
Screenshots (if appropriate):