Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Update icons to Segoe Fluent Icons #13385

Closed
1 of 10 tasks
niels9001 opened this issue Sep 23, 2021 · 11 comments
Closed
1 of 10 tasks

[UX] Update icons to Segoe Fluent Icons #13385

niels9001 opened this issue Sep 23, 2021 · 11 comments
Assignees
Labels
Area-User Interface things that regard UX for PowerToys Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Status-No recent activity no activity in the past 5 days when follow up's are needed

Comments

@niels9001
Copy link
Contributor

niels9001 commented Sep 23, 2021

Since Windows 11 is rolling out soon, and we're adopting more and more the new visual style, now might be a good time to start migrating icons to Segoe Fluent Icons.

For WPF applications, this means we need to embed the .ttf file as I don't believe ModernWPF will automatically select Fluent. It should for Settings, but somehow it's not doing that (probably due to XAML Islands).

We can fix #10331 while at it.

  • Settings
  • OOBE
  • Run
  • FZ Editor
  • Color Picker
  • PowerRename
  • Image Resizer
  • KBM
  • Shortcut Guide
  • Video Conference Mute
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 23, 2021
@niels9001 niels9001 self-assigned this Sep 23, 2021
@niels9001 niels9001 added Area-User Interface things that regard UX for PowerToys and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 23, 2021
@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Sep 25, 2021

  • What font file would you use as a source?
  • One certain Windows Update (21H2 or build 21327 iirc) introduces the mdl2v2 font file by itself. Why not let the OS handle it?
  • Aren't you afraid installing a new font will impact the entire OS? (in case the font hasn't been installed yet)

@niels9001 I've seen so many cases you always manually want to change stuff. Just let the software (OS, xaml, WinUI or whatever...) do the job for you. If the font is already installed, then it's already used. If not yet installed - imagine installing Powertoys and your OS suddenly looks different and you have no idea why or how to fix. I would be pissed!

It should for Settings, but somehow it's not doing that (probably due to XAML Islands).

...but it DOES! As I said earlier, on my Surface I simply installed one font and Windows uses it. Everywhere.
image

refs:
https://docs.microsoft.com/en-us/windows/apps/design/style/segoe-fluent-icons-font
https://docs.microsoft.com/en-us/windows/apps/design/downloads/#fonts

@Jay-o-Way

This comment has been minimized.

@niels9001
Copy link
Contributor Author

  • What font file would you use as a source?
  • One certain Windows Update (21H2 or build 21327 iirc) introduces the mdl2v2 font file by itself. Why not let the OS handle it?
  • Aren't you afraid installing a new font will impact the entire OS? (in case the font hasn't been installed yet)

I don't think you're informed on how this would work: fonts can be easily embedded in the app. So we could embed ' Segoe Fluent Icons' for WPF based apps and reference it directly. We then make sure everything is consistent on W11. By using this method, we wouldn't be touching the OS.

For WinUI/XAML Islands icons should fall back on Segoe Fluent Icons by default on Windows 11. Apparently it does not do that on my machine using TextBlock - not sure if this is a WinUI or a XAML Island bug, but it shouldn't happen. So without manually installing anything FontIcons (red) use the new icons - but then TextBlocks (blue) use Segoe MDL2 Assets.

image

Let's focus on things like #2027 instead. Much more important, if you'd ask me.
I don't see how this is related to this issue?

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Sep 25, 2021

Oh I see. You mean to use the font inside the app(s). That's not as bad as I thought. Still, shouldn't be necessary if OS = Win11, because there it is standard. Right?

The FontIcon versus Textbox is a specific thing. I'mma guess this happens because in some controls the font is explicitly declared to be "Segoe MDL2". If I'm right, that's just one more example not to manual hardcode. This is why CSS was invented in 1994. It's not inside the <controls:settings-expander> but maybe from one of the using:s? Real example:

    <Button 
    x:Uid="EditButton"
    Background="Transparent"
    FontFamily="Segoe MDL2 Assets"

Hm, in my head I had a "link" for that issue, but I guess I just wanted to say that there are other things that have way more priority.

@Jay-o-Way
Copy link
Collaborator

I think, if we use "System icon font" everywhere, this issue would be solved

@Jay-o-Way
Copy link
Collaborator

Is this still an issue? /needinfo

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Status-No recent activity no activity in the past 5 days when follow up's are needed labels Jul 7, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

4 similar comments
@microsoft-github-policy-service
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

@microsoft-github-policy-service
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

@microsoft-github-policy-service
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

@microsoft-github-policy-service
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Status-No recent activity no activity in the past 5 days when follow up's are needed
Projects
None yet
Development

No branches or pull requests

2 participants