-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT Run] Windows Terminal Plugin #13367
Conversation
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentAccessible available chrisharris coc CTriage djsoref docsmsft dogancelik estdir Fody ftps gmx htt inprivate installpowertoys itsme listbox mfreadwrite mfuuid Nefario nitroin null nunit powertoyswiki Radiobuttons sidepanel spamming systray ulazy windevbuildagents winstore xia XSmall xunitSome files were were automatically ignoredThese sample patterns would exclude them:
You should consider adding them to:
File matching is via Perl regular expressions. To check these files, more of their words need to be in the dictionary than not. You can use To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:microsoft/PowerToys.git repository
If you see a bunch of garbageIf it relates to a ... well-formed patternSee if there's a pattern that would match it. If not, try writing one and adding it to the Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines. Note that patterns can't match multiline strings. binary-ish stringPlease add a file path to the File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
|
Does it make sense to show the results when searching for wt/Windows Terminal (Preview) without using activation command (global results). |
@davidegiacometti I have created a .light and .dark icon that might be useful for this plugin :) (and already in the style for #13385) |
@niels9001 I like these icons, but in my opinion it would be better to just use the terminal icon (or at least in the results): |
@niels9001 icon must be used for the settings. |
Why not stick to MDL2? |
Icons for plugins aren't MDL2 but custom |
4c1aacb
to
b326651
Compare
This comment has been minimized.
This comment has been minimized.
Post about result's icon: #4194 (comment) |
I'd go for the colored Terminal icon in Run itself, but the Fluent Icons-version for the plugin manager list in Settings. |
This comment has been minimized.
This comment has been minimized.
edb2a6a
to
e12a8fd
Compare
This comment has been minimized.
This comment has been minimized.
e12a8fd
to
2050604
Compare
The PR is ready to review. Somebody please can build and test the plugin on Windows 11? |
Works nicely on Windows 11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Works well.
I'd still like to have another review in here, but after that it can go in.
Thank you for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, awesome contribution!
Summary of the Pull Request
What is this about:
Open in PT Run Windows Terminal profiles
TO-DO
What is include in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.