Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode: Settings #205

Closed
810 opened this issue Sep 5, 2019 · 14 comments
Closed

Dark Mode: Settings #205

810 opened this issue Sep 5, 2019 · 14 comments
Labels
Idea-Enhancement New feature or request on an existing product Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@810
Copy link

810 commented Sep 5, 2019

Summary of the new feature/enhancement

Add the system theme mode.

Proposed technical implementation details (optional)

Loads the windows ui theme mode.
@indierawk2k2
Copy link
Collaborator

Are you asking for this in FZ, WKSG, settings or something else? Thanks

@goranalkovic
Copy link

Because it's a web app inside Electron (or something similar), querying @media (prefers-color-scheme: dark) should be enough

@RamblingGeekUK
Copy link

It should respect the users setting of Light or Dark Mode

@810
Copy link
Author

810 commented Sep 6, 2019

The only UI is the settings, so i mean settings.

@goranalkovic
Copy link

It should respect the users setting of Light or Dark Mode

With CSS Variables and the media query, that shouldn't be a problem to implement

@enricogior enricogior added Idea-Enhancement New feature or request on an existing product Product-Settings The standalone PowerToys Settings application labels Sep 6, 2019
@bzoz bzoz self-assigned this Sep 6, 2019
@enricogior enricogior mentioned this issue Sep 6, 2019
Closed
@indierawk2k2 indierawk2k2 mentioned this issue Sep 9, 2019
Closed
@birdybro
Copy link

birdybro commented Sep 9, 2019

Simple theme creation should be standard across all these apps with ability to edit colors using HUE/RGB/HTML and saving theme to a file, with a simple location or double click to use. I propose for promotion purposes that MS would do well to officially make a Dracula theme in Power Toys to stand out.

https://github.com/dracula/dracula-theme

@lucknaumann
Copy link

Yay! Dark theme for Settings with version 0.12.0.0. Now, if only there was a dark theme for the Fancy Zones UI...

@enricogior
Copy link
Contributor

@lucknaumann
a dark theme for the FancyZones UI is coming soon ;)

@dpaulino
Copy link

Can we also get dark mode for the title bar?
image

@bzoz
Copy link
Contributor

bzoz commented Nov 21, 2019

We are working on it, it was reported in #732

@crutkas crutkas mentioned this issue Dec 6, 2019
Closed
9 tasks
@jingsong-liu
Copy link

jingsong-liu commented Mar 5, 2020 •
edited
Loading

One more issue about dark mode, many setting buttons are always blue background and black foreground:
image

can we also refine the dark mode color?

@LuminarySage
Copy link

Small interactive elements are supposed to have a desaturated accent in dark theme so that's fine

@crutkas
Copy link
Member

crutkas commented Mar 5, 2020

We'll be be fixed with settings v2 since we'll be directly utilizing brushes from the OS

@SavoySchuler SavoySchuler mentioned this issue Apr 22, 2020
Open
@enricogior enricogior added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label May 25, 2020
@enricogior
Copy link
Contributor

It's not fully supported in 0.18 https://github.com/microsoft/PowerToys/releases

stefansjfw pushed a commit that referenced this issue Dec 18, 2024
@zadjii-msft @zadjii
Add a fallback command for she shell command extension (#207)
b586dd6 
Rebase of #201, onto `main`, to avoid the wacky conflicts circa #200 ~ #205

Can you believe, for a second there, I almost forgot we were building a Run replacement. 


---------

Co-authored-by: Mike Griese <zadjii@gmail.com>
stefansjfw pushed a commit that referenced this issue Dec 18, 2024
@zadjii-msft
Bump our WebView2 version, to fix a bunch of build breaks (#205)
186d411 
WASDK including WebView2 was a mistake. 

Supersedes #200

I also had to:

* Manually restore the WebView2 package into `/packages`. I'm assuming this was just VS being dumb and most people won't have to?
* `git clean -fdx -e *.user -e *.cmd -e packages/** -e Appx/** -e *.svg`  
  * I did it this way because MAYBE i had a couple WIP extensions that I didn't want to nuke, and one .svg file in particular that I yanked from espn.com that I didn't want to nuke
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Idea-Enhancement New feature or request on an existing product Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests