[Settings v2] Restore screen position and size

[enricogior]

Settings v2 should follow the same logic used by the old Settings app.

• by default open in the middle of the screen, not on the top left
• on small screens it should auto resize to a proper height/width

Since it now has the about section, the default width should be large enough to show it on the right and not on the bottom (unless the screen is not large enough).

It should also retain size and position between runs (this is tracked by #3612)

[niels9001]

Can't we just launch it full screen? Normal settings app does this.

[enricogior]

Can't we just launch it full screen?

People with 4K and widescreen monitors would not be very happy (including myself) ;)

Normal settings app does this.

Which settings app are you referring to?

[mdtauk]

UWP apps tend to open large by default - I always resize these windows down, and there is a "sweet spot" with Settings in particular, where the controls fit a 360px approx space, and the breakpoints for the sidebar content places the text to the right, rather than below.

[enricogior]

I don't think we need a discussion for the default, once we support retaining the last size and position.

[mdtauk]

I don't think we need a discussion for the default, once we support retaining the last size and position.

Initial Window Size is the first impression - but once the user resizes and moves the window, that should be what is respected.

[enricogior]

Once it shows in middle of the screen with a reasonable size like this one, we should be good to go.

[niels9001]

Can't we just launch it full screen?

People with 4K and widescreen monitors would not be very happy (including myself) ;)

Normal settings app does this.

Which settings app are you referring to?

Oh yes.. that makes sense :)! I was referring to the W10 Settings app. I wonder if Windows / UWP windowing have different behaviors when an app gets launched on a 4k 27" display vs. 15" laptop.

Launching it in the middle in a reasonable size sounds good 👍

[crutkas]

https://stackoverflow.com/questions/847752/net-wpf-remember-window-size-between-sessions

[davidegiacometti]

In the past I have made something similar and I had trouble with the main window maximized on a secondary monitor.
I have made a simple POC https://github.com/davidegiacometti/restore-window-poc using SetWindowPlacement and GetWindowPlacement that is properly handling that case.

[Jay-o-Way]

I'm still experiencing an issue on my Surface. It has a 200% scaling (because of the high resolution and relative small physical size) and the window doesn't open in the middle, the bottom is actually off-screen. I think I know where (in the code) the problem is. Should I mention that in this issue or open a new one?

[enricogior]

@Jay-o-Way
we didn't do any fix for this, so this issue is still the issue to track this problem.

[Jay-o-Way]

In that case...

I was looking at settings/main.cpp and saw - starting at line 406 - the following:

HWND create_main_window(HINSTANCE hInstance)
{
    RECT desktopRect;
    const HWND hDesktop = GetDesktopWindow();
    WINRT_VERIFY(hDesktop != nullptr);
    WINRT_VERIFY(GetWindowRect(hDesktop, &desktopRect));

    int wind_width = 1024;
    int wind_height = 700;
    DPIAware::Convert(nullptr, wind_width, wind_height);

    return CreateWindowW(
        L"PTSettingsClass",
        L"PowerToys Settings",
        WS_OVERLAPPEDWINDOW,
        (desktopRect.right - wind_width) / 2,
        (desktopRect.bottom - wind_height) / 2,
        wind_width,
        wind_height,
        nullptr,
        nullptr,
        hInstance,
        nullptr);
}

I see that there is DPI "correction" for the window size, not for the display resolution.

numbers in brackets are what I call DPI-corrected numbers

I could make a screenshot of the window's first position on my Surface, if wanted?

[enricogior]

@Jay-o-Way
that's OK, I can also reproduce it on my laptop. Thanks.

[Jay-o-Way]

Well, turned out I was off, quite a bit. It does show in the horizontal center, but not in the vertical middle. Is there another function moving/resizing the window after it is opened?
Anyways, this is the screenshot of the window at first sight, scale @ 200%:

Initial window size approx 2174 x 1590 pixels. Top-left corner is at 303x293 pixels.

[Jay-o-Way]

When I change scale to 100%, this is the initial position:

Top-left corner at almost 150x150 pixels.

If I change the scale back to 200% while the window is open, is does get moved in the work-area of the desktop, so that (WM_DPICHANGED?) is working good.
Clicking the tray-icon to open the window messes it up, but weird enough not 100% of the time. The position (left/top) changes alot every time I open the window. I'm gonna guess it's somewhere in the open_settings_window() function. I don't know. It's really difficult to understand all those different files and functions. #NeedMoreComments

[kethan1]

@enricogior any plan on fixing this soon? This issue's pretty annoying, anything stopping this from being fixed?

[enricogior]

@kethan1
as you can see on the right column of this issue, it is planned for the 0.33 release

We have hundreds of known issue, it would be great to be able to fix all of them in a few days/weeks but we are a small team with limited bandwidth.

[enricogior]

#10022 fixes the default location for the new Settings and also guarantees that the Settings (and OOBE) are always inside the screen work area.
The default location is center screen.
Changing the title to reflect that the remaining work for this issue is to save the position/size and use it when the Settings/OOBE is reopened.

[dedavis6797]

@jaimecbernardo based on @enricogior 's last comment, is this something we can likely knock out in v0.45? Or should we allot more time?

[jaimecbernardo]

This feels more like a nice to have, plus if done in a rush it can lead to new issues (improperly detecting that the position/size saved are no longer valid, for example). I think we still have higher priorities here, so we should push this back.

[dedavis6797]

Resolved with v0.49.0. Thanks @davidegiacometti!