[Settings] Restore window size and position

[davidegiacometti]

Summary of the Pull Request

What is this about:
Restore settings window size and position

What is include in the PR:

• Using GetWindowPlacement and SetWindowPlacement to restore settings window size and position
• Also checking if the restored windows is offscreen and rollback to default
• Aware of multiple monitors and scaling

Let's discuss about this solution. Should I add try-catch to be more safe?

How does someone test / validate:

• Validate that settings window is always restored and visibile

Quality Checklist

• Linked issue: [Settings v2] Restore screen position and size #3685
• Communication: I've discussed this with core contributors in the issue.
• Tests: Added/updated and all pass
• Installer: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Docs: Added/ updated
• Binaries: Any new files are added to WXS / YML
  • No new binaries
  • YML for signing for new binaries
  • WXS for installer for new binaries

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

[jaimecbernardo]

Hi @davidegiacometti , as you've mentioned, I think catching exceptions on JSON reading/parsing in order to revert to default might be good.
I'm not aware of all the possible error handling here, but checking for errors in order to revert to default is a good starting point here.

[jaimecbernardo]

Nice work! 😄

I think a couple of changes are still needed.
Some better error handling, reverting to default, as mentioned in the description.
If the previous window position is partially out of a monitor it still displays the Windows cut. It should revert to default when the Windows is partially offscreen, I think.

[jaimecbernardo]

LGTM!
Thank you for the contribution!