Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ClearType in PT Run #4172

Closed
AnuthaDev opened this issue Jun 7, 2020 · 9 comments
Closed

Enable ClearType in PT Run #4172

AnuthaDev opened this issue Jun 7, 2020 · 9 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@AnuthaDev
Copy link

AnuthaDev commented Jun 7, 2020

Summary of the new feature/enhancement

After the migration from XAML islands to WPF, text rendering of PT Run on my 1366x768 display is unbearable. My eyes hurt looking at the text. This is because ClearType is not enabled.

Proposed technical implementation details (optional)

After some fiddling around with code, this is what needs to be done:

  1. Modify DropShadow in MainWindow.xaml

  2. Enable ClearType in TextBox

  3. Enable Overall ClearType by setting RenderOptions.ClearTypeHint to Enabled and TextOptions.TextFormatting to Display in MainWindow.xaml

After applying the above patches, PT Run text rendering is fantastic on my screen. But we would need to make sure it does not cause regressions in high res displays (which I don't have😅)

@crutkas I would like to work on it :)

@crutkas
Copy link
Member

crutkas commented Jun 7, 2020

Cool. A screenshot for showing blurriness would be helpful too.

@AnuthaDev
Copy link
Author

AnuthaDev commented Jun 7, 2020

@crutkas Yeah, well, Unfortunately my screen is so low res you can't even see the blurriness(in a screenshot)...so, I guess after I send a PR maybe someone with a better screen could do that 😅

@saahmedm saahmedm added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Help Wanted We encourage anyone to jump in on these and submit a PR. labels Jun 9, 2020
@royvou
Copy link
Contributor

royvou commented Jul 21, 2020

Looks like AnuthaDev has abandoned his PR, the PR looks good apart from the multiple "Windows Versions" upgrade.
@AnuthaDev will you be still working on it/reopening this PR?

@AnuthaDev
Copy link
Author

@royvou I actually messed up my branch so I had to abandon that PR😅😅. Don't worry, working on it now :)

@royvou
Copy link
Contributor

royvou commented Jul 21, 2020

No worries, good to know if it still active :) !

@arjunbalgovind
Copy link
Contributor

MicrosoftTeams-image (9)
Here's a screenshot since we don't have one on the issue. Easy to repro by running a VM at a lower resolution (1366x768)

@crutkas
Copy link
Member

crutkas commented Aug 14, 2020

From #5920, screen resolution is 768x1366, with an 100% scaling,

@AnuthaDev
Copy link
Author

AnuthaDev commented Aug 14, 2020

From #5920, screen resolution is 768x1366, with an 100% scaling,

That's exactly the same as mine. I believe this PR would only significantly improve lower than FHD screens.

@crutkas crutkas added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 21, 2020
@crutkas
Copy link
Member

crutkas commented Sep 8, 2020

Fix added in 0.21.1, please go to https://github.com/microsoft/PowerToys/releases to upgrade

@crutkas crutkas closed this as completed Sep 8, 2020
@github-project-automation github-project-automation bot moved this to ⚠️Needs Walkthrough in 3. Help Wanted Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
Status: ⚠️Needs Walkthrough
Development

No branches or pull requests

5 participants