[PT Run] Updated themes (dark/light/highcontrast)

[niels9001]

Summary of the Pull Request

• Added a brush for 'secondary text' (instead of primary text font with a lower opacity)
• Minor updates to the Light and Dark themes to reflect the updated secondary text brush
• Added a BorderThickness of 1 to visualize the border when a high contrast theme is selected. Transparant for Light and Dark
• Updated the high contrast themes, to reflect the default high contrast settings.

Merge together with #4165 so the correct colors/themes are applied.

PR Checklist

• Applies to Theming for powertoys run #4007
• CLA signed. If not, go over here and sign the CLA

[dsrivastavv]

This is amazing 🔥.

[htcfreek]

@niels9001
Will this influence #2988 while merging?

[crutkas]

#2988 I really wish there was a larger discussion on before the work was done

[AnuthaDev]

Hey @niels9001 Can you please separate the border brushes of searchbox and resultlist box, so as to not impact #2988😊

[niels9001]

@AnuthaDev That might be an issue, yes. Not sure where we are with that PR, so let's follow up there - I'm happy to make any changes if needed to solve a potential conflict

I saw your comment about breaking ClearType due to (semi)-transparency. What specific brushes are impacted at the moment that you'd recommend to update? And is there any documentation I can check out, wasn't aware of this.

[AnuthaDev]

@niels9001 Read the remarks section here:

https://docs.microsoft.com/en-us/dotnet/api/system.windows.media.renderoptions.cleartypehint

[AnuthaDev]

If you want to dive really deep:

microsoft/terminal#5277

[crutkas]

The PR #2988 is a good idea but it was work done without collaboration. Niels helped properly get our HC settings correct in this PR.

[niels9001]

@AnuthaDev The latest commit changed the transparency to fully opaque colors - let me know if this solves your concern wrt ClearType. Only the 'focus' color (AccentBrush) is still using opacity, we might want to update that as well but maybe in a new PR.

[AnuthaDev]

@niels9001 Unfortunately its a bit trickier than just fixing colors, because we are using a dropshadoweffect, We need to apply this fix to get clear text. I think a new issue should be opened for cleartype after this PR is merged.

[AnuthaDev]

Opened #4172 for cleartype

[crutkas]

@niels9001, we're going to merge this in, cool?

[niels9001]

@niels9001, we're going to merge this in, cool?

Cool!

[AnuthaDev]

@crutkas this conflicts with #4180

[AnuthaDev]

(Can't have a borderbrush if you have no borders.. )

[niels9001]

(Can't have a borderbrush if you have no borders.. )

Not sure if I understand - what specific lines/controls?

Borders for both SearchBox and ResultsList have a BorderThickness of 1 (line 57 and 78).

They are set to transparent in the light/dark themes - white/black when in high contrast mode, following the W10 windowing appearance.

Let me know!

[AnuthaDev]

@niels9001 In MainWindow.xaml, I had to replace the Border containers by Grid to improve font rendering, so the border being set to 1 won't work as there would be no border.

Anyways, I found the solution, I will rebase and fix the issue. @crutkas Good to go👍