Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] remove legacy code that migrates FZ settings from the registry #6659

Closed
enricogior opened this issue Sep 16, 2020 · 1 comment
Closed

[FancyZones] remove legacy code that migrates FZ settings from the registry #6659

enricogior opened this issue Sep 16, 2020 · 1 comment
Assignees
@stefansjfw
Labels
Area-Quality Stability, Performance, Etc. Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@enricogior
Copy link
Contributor

We are considering fixing #6321 in 0.24, it will require to switch from using the monitor ID to use the monitor serial number.
The work will have a great impact and it will require a lot of testing. To reduce the complexity of that migration we would remove all legacy code that is not strictly necessary to maintain.
The registry migration at this point is not anymore a high priority and removing it it will greatly simplify the testing for #6321
Since the registry migration will be removed, we can also add code to clean up the registry if the SuperFancyZones key is still present.
@enricogior enricogior added Product-FancyZones Refers to the FancyZones PowerToy Area-Quality Stability, Performance, Etc. labels Sep 16, 2020
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 16, 2020
@enricogior enricogior mentioned this issue Sep 16, 2020
Merged
5 tasks
@stefansjfw stefansjfw self-assigned this Sep 17, 2020
@stefansjfw stefansjfw added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 17, 2020
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 17, 2020
@enricogior
Copy link
Contributor Author

Fixed in 0.23.0 https://github.com/microsoft/PowerToys/releases/tag/v0.23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefansjfw stefansjfw

Labels
Area-Quality Stability, Performance, Etc. Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crutkas @enricogior @stefansjfw