Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] Remove migration from registry logic and delete registry data if present #6657

Merged
merged 2 commits into from
Sep 17, 2020
Merged

[FancyZones] Remove migration from registry logic and delete registry data if present #6657

merged 2 commits into from
Sep 17, 2020

Conversation

stefansjfw
Copy link
Collaborator

@stefansjfw stefansjfw commented Sep 16, 2020 •
edited by enricogior
Loading

Summary of the Pull Request

What is this about?
Do not migrate custom layouts from registry on first PowerToys run. Also, if FancyZones registry data is present in registry, delete it.

PR Checklist

Validation Steps Performed

How does someone test & validate?
Scenario #1

  1. Delete FancyZones JSON files
  2. Confirm that there is some FancyZones data present in registry (Layouts subkey)
    3, Start PowerToys
  3. Open FancyZones JSON files and confirm that no data was migrated from registry

Scenario #2

  1. Start PT with FZ enabled
  2. (If there was any FZ data in registry) Confirm that SuperFancyZones registry key is deleted

enricogior
enricogior reviewed Sep 16, 2020
View reviewed changes
src/modules/fancyzones/lib/FancyZonesData.cpp
@@ -60,6 +59,84 @@ namespace

return tmpDirPath;
}

bool DeleteRegistryKey(HKEY hKeyRoot, LPTSTR lpSubKey)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this as simple as possible: try to delete the SuperFancyZones key and if it fails we don't care.

@enricogior enricogior added the Product-FancyZones Refers to the FancyZones PowerToy label Sep 16, 2020
@stefansjfw stefansjfw merged commit b5cc24f into microsoft:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vldmr11080 vldmr11080 vldmr11080 approved these changes

@enricogior enricogior enricogior approved these changes

Assignees
No one assigned
Labels
Product-FancyZones Refers to the FancyZones PowerToy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefansjfw @enricogior @vldmr11080