Mouse Utils - Mouse Highlighter #14496
Conversation
jaimecbernardo
requested review from
crutkas,
yuyoyuppe,
SeraphimaZykova,
niels9001,
stefansjfw and
dedavis6797
|
Lets add an extra expander to group the layout and behavior settings. |
Tweaked. |
Updated in description |
|
@jaimecbernardo |
| } | ||
| } | ||
|
|
||
| void parse_settings(PowerToysSettings::PowerToyValues& settings) |
There was a problem hiding this comment.
Shouldn't PowerToyValues be const?
There was a problem hiding this comment.
get_raw_json is not const. (It's possible it could be, but that's out of the scope of this PR)
|
Noticed that settings and logs are in the different folders.
|
Addressed in #14130 |
| try | ||
| { | ||
| // Parse Opacity | ||
| auto jsonPropertiesObject = settingsObject.GetNamedObject(JSON_KEY_PROPERTIES).GetNamedObject(JSON_KEY_HIGHLIGHT_OPACITY); |
There was a problem hiding this comment.
couldn't we use src\common\utils\json.h in this file?
There was a problem hiding this comment.
I've based the code on what I saw for ShortcutGuide and some other PowerToys.
So we have two different libs for this?
What's the issue with using this one vs the other?
|
Thank you for the code reviews. I've addressed or answered them. PTAL. |
Jay-o-Way
added
the
Product-Mouse Utilities
|
@jaimecbernardo , @niels9001 |
Summary of the Pull Request
What is this about:
Adds a new PowerToy called "Mouse Highlighter", under "Mouse Utilities".
This PowerToys can be used to highlight left and right mouse clicks while presenting/screen sharing.
Default activation key is Windows+Shift+H.
What is include in the PR:
How does someone test / validate:
Start PowerToys with the module enabled and press "Windows"+"Shift"+"H". Then left and right click with the mouse to check the effect. "Windows"+"Shift"+"H" to toggle it off again.
Quality Checklist