[meta]git ignore monaco generated installer file #15763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansjfw
approved these changes
Jan 25, 2022
|
Why exactly does this get generated? |
So installer could pick up the monacoSRC directory tree |
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
After #15138 , building the installer creates
installer/PowerToysSetup/MonacoSRC.wxs, which gets recognized as a new file by git.What is included in the PR:
Add the generated file to
.gitignoreso it doesn't get included in any future PRs by mistake.How does someone test / validate:
Build the installer, verify
installer/PowerToysSetup/MonacoSRC.wxsisn't listed withgit statusas an untracked file to add.Quality Checklist