Fallback to run as admin after install, if running PT as user not possible #16089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansjfw
force-pushed
the
stefan/fix_run_as_non_admin_user
branch
from
56d2f2b to
6b6edf5
Compare
src/runner/main.cpp
Outdated
| restart_same_elevation(); | ||
| result = -1; | ||
| Logger::warn("Scheduled restart failed. Trying restart as admin as fallback..."); | ||
| restart_elevated(); |
There was a problem hiding this comment.
Why are trying to restart elevated? Seems strange that it would work for the issue people are having. How about doing a debug build to verify this.
There was a problem hiding this comment.
I tested it locally. The issue can easily be reproduced if you just try to install PowerToys on non-admin user.
The issue is happening because how we're trying to run non-elevated from elevated admin owned process. So we try to run non-elevated, if it fails, run elevated as it was working before.
yuyoyuppe
reviewed
Feb 4, 2022
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
stefansjfw
force-pushed
the
stefan/fix_run_as_non_admin_user
branch
from
c14ddcf to
db6baf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
What is included in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.