Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oobe] fix scoobe page threading issues #16532

Merged

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

What is this about:
The use of await in the "What's New" page is not returning to the UI thread as expected, even if context should be maintained as mentioned in the await documentation. This happens when running PowerToys.Settings directly when debugging from VS. This might be a XAML islands quirk and might happen in other situations, as well, so let's make sure it runs in the right thread.

What is included in the PR:
Dispatch code to the right thread after await, before doing UI element changes.

How does someone test / validate:
Just looking for that Code Quality check, but running scoobe to make sure it still works is fair game as well.

Quality Checklist

  • Linked issue: Upgrade User OOBE experience (SCOOBE) #14536
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed PT, What's new shows and works good.
Also running Settings directly from VS does not throw any exceptions and works correctly

@jaimecbernardo jaimecbernardo merged commit d5fc454 into microsoft:main Feb 23, 2022
mshtang pushed a commit to mshtang/PowerToys that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants