Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installer]Include PTRun WindowsTerminal loc #16777

Merged

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

What is this about:
Installer is not including localization resources for the Windows Terminal plugin.

What is included in the PR:
Uncomment the installer instructions that will include localization for the plugin.

How does someone test / validate:
Let's wait for a CI Build and see if it localizes the plugin.

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaimecbernardo jaimecbernardo merged commit 6b6ba22 into main Mar 4, 2022
jaimecbernardo added a commit that referenced this pull request Mar 4, 2022
* [Installer]Include PTRun WindowsTerminal loc

* Add languages folder reference
@jaimecbernardo jaimecbernardo deleted the dev/jaimecbernardo/ptrun-windowsterminal-enable-loc branch March 4, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants