Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings]Fix WinUI3 publish issues #17817

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

What is this about:

After #17797 , settings won't open when ran from the installer.
The main reason for it is that after running publish for building the installer, it's not properly configured to use the proper "win10-x64" runtime identifier.

What is included in the PR:

How does someone test / validate:
After release CI pipelines build, give it a test.

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@jaimecbernardo jaimecbernardo requested a review from crutkas April 20, 2022 00:55
@jaimecbernardo
Copy link
Collaborator Author

Just adding a docs update commit. Build from release pipeline will still be valid.

@crutkas
Copy link
Member

crutkas commented Apr 20, 2022

Signing got stuck again. I kicked off a new build.

@stefansjfw stefansjfw merged commit 40300c1 into main Apr 20, 2022
@crutkas crutkas deleted the dev/jaimecbernardo/upgrade-winappsdk-1.0.3 branch April 20, 2022 18:45
@Jay-o-Way Jay-o-Way added the Product-Settings The standalone PowerToys Settings application label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Settings The standalone PowerToys Settings application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants