Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM64] Add support for .msi assembly #17861

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

yuyoyuppe
Copy link
Contributor

@yuyoyuppe yuyoyuppe commented Apr 21, 2022

Summary of the Pull Request

What is this about:

What is included in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: Support ARM platform #490
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

# Conflicts:
#	installer/PowerToysSetupCustomActions/PowerToysSetupCustomActions.vcxproj
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was win32 added in the solution?

@yuyoyuppe
Copy link
Contributor Author

yuyoyuppe commented Apr 21, 2022

@jaimecbernardo wix toolset doesn't support arm64, so we're compiling it as x86

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubbertsamp LGTM!
Changes looks fine and CI is building, so x64 installer is not broken.
Thank you!

@jaimecbernardo jaimecbernardo merged commit 31c54c9 into microsoft:main Apr 21, 2022
@yuyoyuppe yuyoyuppe deleted the arm64/msi branch April 21, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants