[PowerRename] Move to WinAppSDK WinUI3 Unpackaged & ARM64 Support #18171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate PowerRename to Unpackaged WinUI3 * Removed Project Config and update PlatformToolset to v143 * Updated solution config * Migrate PowerRename to Unpackaged WinUI3 * Fixed configs changed from ARM64 build * Left one project out of fix Co-authored-by: Stefan Markovic <stefan@janeasystems.com> Co-authored-by: Stefan Markovic <57057282+stefansjfw@users.noreply.github.com>
stefansjfw
requested review from
crutkas,
yuyoyuppe,
SeraphimaZykova and
jaimecbernardo
|
@jaimecbernardo Could you trigger release build? I'm interested in localization.. :) |
|
@stefansjfw , just started it. |
|
@stefansjfw Can you provide a bit more info about the what and why? I see you mention PowerRename in the title but I see many more things affected. |
|
@Jay-o-Way There are few reasons for this.
Many projects are affected with this changes because of the used nuget packages needed version bump |
|
NOTE: As WinAppSDK 1.0.3 is used for PowerRename, it'll suffer from the same elevation crash as Settings app!! |
|
Thanks for the info. Might be good to move that to the main body. |
|
wow |
Remove move_uwp_resources.ps1 - not needed anymore
stefansjfw
force-pushed
the
stefan/pr_winui3
branch
from
00477c5 to
fffb6d6
Compare
SeraphimaZykova
approved these changes
May 11, 2022
|
Localization is preserved now. |
yuyoyuppe
approved these changes
May 11, 2022
jaimecbernardo
approved these changes
May 11, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Co-authored by: @snickler
What is this about:
What is included in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.