Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM64] Preview pane changes #18222

Merged
merged 4 commits into from
May 11, 2022

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

What is this about:
Changes to properly build multi-platform preview pane modules, since they have to be published if they have binary components like WebView 2.

What is included in the PR:

  • Publish preview handler modules. (Makes WebView2 loader be on the same path as the preview dlls)
  • Change project files to build for ARM64.

How does someone test / validate:
Installer still builds correctly and preview modules can be used correctly.

Quality Checklist

  • Linked issue: Support ARM platform #490
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@Jay-o-Way Jay-o-Way requested a review from Aaron-Junker May 11, 2022 14:17
@jaimecbernardo
Copy link
Collaborator Author

Tested result from the release pipelines. Modules are still running correctly.

@jaimecbernardo jaimecbernardo merged commit 2555203 into main May 11, 2022
@jaimecbernardo jaimecbernardo deleted the dev/jaimecbernardo/arm64-preview-handlers branch May 16, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants