Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installer]Add version to the winappsdk filename #18543

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

What is this about:
Add the version to WindowsAppRuntimeInstall.exe so that it doesn't collide with other installers the user might've downloaded for windappsdk, since all the installers are named WindowsAppRuntimeInstall.exe regardless of version.
The Wix bootstrapper will prefer to use a local installer if one is found and it will have the wrong hash if it's not the same version.

What is included in the PR:
Add the version to WindowsAppRuntimeInstall.exe file name.

How does someone test / validate:
Download a different version installer for windowsappsdk to the same path as the PowerToys installer and verify PowerToys is still able to install windowsappsdk without receiving a wrong hash error.

Quality Checklist

  • Linked issue: Support ARM platform #490
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

@jaimecbernardo jaimecbernardo merged commit 368c775 into microsoft:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants