Enabling key accelerators on context buttons. #2232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Allows users to use shortcuts for actions specific to the selected row. eg. CTRL-SHIFT-ENTER = Run as Admin, Ctrl-Shift-E open folder location, etc.
References
Detailed Description of the Pull Request / Additional comments
@crutkas . #1 is an explicit breaking change if we plan to support Wox plugins directly. However, I would rather be explicit with the data type, and write and adapter if we need to support existing wox plugins in the future. The design of how these actions are executed is quite different, so I doubt wox plugins would work out of the box anyway right now.
Validation Steps Performed
The following items are being validated by setting breakpoints on each of the modified actions and verifying that the action triggers from the expected accelerator keys