-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quickaccess systemtray launcher #22408
Conversation
Wire up colorpicker and pt run
…t/PowerToys into feature/sytrayflyoutpoc
This comment has been minimized.
This comment has been minimized.
@niels9001 Here are some thoughts/ideas:
|
Support for easy turning on/off would especially be useful for KBM. I use it when my laptop is undocked to make the condensed keyboard’s alternate Fn behavior (PrtSc, Home, Ins) of F9 F10 F11 keys the main behavior for editing convenience, and so that other function keys behave in programs as their usual purpose, like F3 find-next, F5 refresh, etc. When docked I turn it off because the bigger keyboard has separate PrtSc, Home, and Ins keys, leaving F1-F12 normal. |
I think this idea is amazing and I'd love to see it in whatever form is best. I think being able to turn on/off all modules from here would be a bit much and overcomplicate it, but options for Awake or KBM could be good. Besides, Settings is just one click away from here. (Although maybe such an option could be added via a context menu when right-clicking a module?) I also think the file icon for documentation isn't immediately obvious; I'd also agree with using a question mark or help icon would be better. Either way, I'd love to see this added in! |
My opinion is that like this it imitates the Windows 11 quick action center, ehich primarly is for turning things on/off. I don't think it's very intuitive to use the same design, but a different functionality. |
Fair point - not sure if it'll be a major hurdle, but if so we could adopt the Start Menu grid-like design as it's more inline with app launching. |
What's the point of showing the hosts file editor there? That can be launched with just the exe file (at program files\powertoys\modules). As I see it, this is much better suited to launching things that are otherwise accessible only with the keyboard, like Run, the colour picker or the OCR recogniser. Besides I don't think there's a lot of people that need to edit the hosts file so often that they need a "quick access" thingy for it. If they do, as I said, they can just make a shortcut to its exe file. Other than that I think it looks cool :D |
I think we need a Discussion to poll ideas from users. I feel there are different interpretations from us already, so we should ask the users. |
I've removed VCM from the list of apps. It's legacy and it's only controllable when running as admin. Best leave it out. |
… only if there is no page opened
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -41,7 +41,7 @@ public void LogOpeningSettingsEvent() | |||
|
|||
public void LogRunningModuleEvent() | |||
{ | |||
PowerToysTelemetry.Log.WriteEvent(new OobeModuleRunEvent() { ModuleName = this.ModuleName }); | |||
PowerToysTelemetry.Log.WriteEvent(new TrayFlyoutModuleRunEvent() { ModuleName = this.ModuleName }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change looks wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're very right! Just fixed it. I used that event as a basis and then changed the wrong one. 🤦 It should be good now.
Changed the BitmapIcons to Images with BitmapImages, as those don't have the "flickering" behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work! ;)
And thank you for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I like the flyout very much! I gave it a test, everything works well.
} | ||
|
||
/// <summary> | ||
/// Set flyout opening callback function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment is wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it. Thanks for the review!
Summary of the Pull Request
This PR introduces a new way of launching various PowerToys modules by clicking on the icon in the system tray.
Features:
Things to do:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed