-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Settings] Mica & modern titlebar #25936
Conversation
@niels9001 |
And did you miss to push the debug label code? |
<Window x:Class="MyApp.MainWindow">
<Window.SystemBackdrop>
<MicaBackdrop MicaKind="BaseAlt"/>
</Window.SystemBackdrop>
</Window>
|
We use it for more than just |
Mica & modern titlebar in settings! 😍 I don't have any problem with PowerToys is still using 2.1 at the moment. |
Yeah, and we'd need to update to the latest WASDK so that we can set it in XAML.. I believe there was a crash preventing this and you'd need to manually set it in code behind. I'd let this go in as is, and then do a PR updating WinUIEx/WinAppSDK and replacing the WinUI backdrops with the WASDK backdrops. |
Think we just upgraded to app sdk 1.3.1 |
Yeah, main is on 1.3.1 already. |
@Jay-o-Way @jaimecbernado @crutkas Updated to WinUIEx and removed the WinUIEx mica backdrops. Still using the WinUIEx Acrlyic for the flyout though, as the default Anyways - this PR is ready for review. But maybe to wait until 0.70 is released to get this in? |
I’m inclined to wait at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working and looking good! 👍🏻
Why wait?
I've pushed a fix for the build issue. |
Also, isn't the WinUIEx upgrade #26000 ? This one seems to upgrade it as well. |
Yeah, it was needed for this PR as well with the latest APIs and bugfixes. Feel free to merge that first.. this PR is ready for review! |
Added a missing NOTICE.md entry to try to get CI to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing
I have no idea.. seeing the same thing. When putting this PR in I'm 100% sure this was tested and it worked as expected 😣. When debugging, it seems that the |
Alright. Anyway, theme does change eventually and it sounds like low priority. I'll open an issue after merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution! Works well on both Windows 10 and Windows 11.
I'll open an issue for the new theme change delay this PR seems to bring.
* Adding Mica * Working Mica * Fluent titlebar * Modern titlebar * Fixing OOBE * Fix build issue * Add missing entry to NOTICE.md * Update App.xaml.cs
Summary of the Pull Request
NavigationView.PaneToggleButton
to the titlebar so we have more vertical spaceWinUIEx.Backdrop
toWindow.SystemBackdrop
.Titlebar - before vs. after
Mica
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed