Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] React on OS theme change fix #29944

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Conversation

stefansjfw
Copy link
Collaborator

Summary of the Pull Request

Register theme listener properly to react to OS theme change immediately.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Open Settings app
  • Ensure Theme setting is set to "Windows default"
  • Change OS Theme settings and observe that Settings app changed it's theme properly
  • Ensure that different Theme settings work as expected

@Jay-o-Way
Copy link
Collaborator

Just to check: Are HighContrast themes independent of the light/dark bits?

@Jay-o-Way Jay-o-Way self-requested a review November 21, 2023 11:55
Copy link
Collaborator

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice, thanks!

Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all variants (inc. different High Contrast themes and moving between HC to light/dark and vice versa). Works great :)!!

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Working so much better and much simpler now. Thank you!

@jaimecbernardo jaimecbernardo merged commit faea17b into main Nov 23, 2023
14 checks passed
@stefansjfw stefansjfw deleted the stefan/fix_settings_theme branch November 24, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants