-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#27712] PowerToys New+ v0.1 #33136
[#27712] PowerToys New+ v0.1 #33136
Conversation
Made ThemeRegistryHelper protected
Removed New.wxs from installer
Restored logger_helper.h
Updated resources to have the right white space formatting
Replaced tabs with spaces
Added GPO info to GPO assets and fixed bug while testing GPO support
Added files for signing
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution.
I made a small comment on the policy name.
@microsoft-github-policy-service agree |
…ddress feedback from htcfreak Update GPO setting name to reference NewPlus rather than just New - Address feedback from htcfreak
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the best to rename all places (docs, code, directory, installer) where the utility is called "New" to "NewPlus".
New
can be read as new item
and is confusing then.
What is required to get this in? Waiting for it. |
Trying to get the branch to build again so we can re-review :) |
I've pushed a commit to fix spellcheck entries that seemed unneeded. a5403e6 |
I've pushed a commit to fix an issue I've found while testing: if all templates were folders, the samples would be copied again. 2e07256 |
I've pushed a commit so that Bug Report doesn't send the user templates inside the PowerToys settings folder, in case the user is still using the default location and might not want to link his teamplates. c69d94b |
I've pushed a commit to show a warning on Windows 10. bcfbac2 |
This comment has been minimized.
This comment has been minimized.
I've added a infobox to inform users that Backup and Restore won't work with templates: 56610a5 |
I've added a commit with more specific telemetry names: dda6cec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well! And it's looking good to me!
Thank you for the contribution!
@cgaarden congrats on getting this merged! I'm super stoked to see this get released. |
Summary of the Pull Request
This PR contains the first very early version of New+ (#27712)
New+ is a new PowerToys for the File Explorer that enables users to create files and folders from a personalized set of templates.
Issue:
#27712
Spec:
https://1drv.ms/w/s!AgfnseFPEL1w2NklIIJb2hDgHkz6MQ?e=b8rSuL
This PR includes:
• Early version of New+
• New+ Windows 11 File Explorer support
• Dark and Light System Theme support
• Logging + Trace
• New+ GPO settings
• New+ Settings page
• New+ What's new page
• New+ example templaes
• New+ uninstall support
Closes: Create new file from a list of customizable templates straight from the folder context menu #27712
This doesn’t close Create new file from a list of customizable templates straight from the folder context menu #27712 yet
Communication: I've discussed this with core contributors already.
Tests: Added/updated and all pass
Localization: All end user facing strings can be localized
[ X] Dev docs: Added/updated
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed