Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installer]Create DSC module in right path for user installs #33782

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

User-scope installer is putting the module in "Modules\Microsoft.PowerToys.Configure\v0.0.1" instead of "Modules\Microsoft.PowerToys.Configure\0.0.1".
This PR fixes that use of the PowerToys version to not include the "v".

PR Checklist

Validation Steps Performed

Build the user install, installed it and tested to see if DSC ran correctly.

Copy link
Collaborator

@drawbyperpetual drawbyperpetual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fix tested - install and uninstall work correctly, as do the DSC commands.

@jaimecbernardo jaimecbernardo merged commit 57b06fa into main Jul 11, 2024
14 checks passed
@crutkas crutkas deleted the dev/jaime/fix-wrong-user-DSC-folder branch July 22, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants