-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaked OS Detection project structure and added os check for PT Run #4253
Tweaked OS Detection project structure and added os check for PT Run #4253
Conversation
@@ -132,60 +133,64 @@ class Microsoft_Launcher : public PowertoyModuleIface { | |||
// Enable the powertoy | |||
virtual void enable() | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change made on this file was the following:
Earlier it was
enable()
{
logic;
m_enabled=true;
}
Now it is
enable()
{
if (UseNewSettings())
{
logic;
}
m_enabled = true;
}
@enricogior this solves #3730 and partially solves some of the issues in #3579 . I have still kept the dll since it is required for Image Resizer so that it can make it's old settings UI visible when the OS version is older than 19h1. |
@arjunbalgovind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Summary of the Pull Request
This PR fixes the issue of PowerLauncher.exe getting launched on OS version less than 19H1 and also makes a few changes to the os-detection project structure.
common
project. That way we can use the functions in C++ executables/dlls directly by referencing and without requiring os-detection.dll in that folder.References
PR Checklist
Validation Steps Performed
Verified that behavior is as expected for Launcher/ImageResizer/Settings on 1909, 1809 VM and an internal build number VM. Only for the 1809 VM the old settings would be loaded, image resizer would use its old settings UI, and PowerLauncher.exe would not be launched.