-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Localization] Move PowerToys Run string resources from xaml files to resx #6165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunbalgovind
added
Product-PowerToys Run
Improved app launch PT Run (Win+R) Window
Area-Localization
issues regarding to Localization the application
labels
Aug 25, 2020
3 tasks
dsrivastavv
reviewed
Aug 26, 2020
src/modules/launcher/Plugins/Microsoft.Plugin.Folder/ContextMenuLoader.cs
Show resolved
Hide resolved
dsrivastavv
reviewed
Aug 26, 2020
dsrivastavv
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Localization
issues regarding to Localization the application
Product-PowerToys Run
Improved app launch PT Run (Win+R) Window
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
This PR removes all the language xaml files in the PowerToys Run projects and plugin projects and adds an english resx file with the strings, and enables its localization on the pipeline. The
Internationalization
related classes inWox.Core.Resources
were also removed as they were no longer required.PR Checklist
Info on Pull Request
What does this include?
GetTranslation
by directly referencing the resource with the statementProjectName.Properties.Resources.resourceName
.Internationalization
andLanguage
related classes were removed since there were used only for the Language xaml files. Since this containedGetTranslation
, theGetTranslation
method was removed fromIPublicAPI
as well.GetTranslation
. Instead of checking for a call with a resource name, it was changed to check the values set for the context menu item titles.langCode\ProjectName.resources.dll
.Pending Work (to be done in a separate PR)
Validation Steps Performed
How does someone test & validate?