Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with autocomplete text not getting cleared #6220

Merged

Conversation

dsrivastavv
Copy link
Contributor

@dsrivastavv dsrivastavv commented Aug 28, 2020

Summary of the Pull Request

Autocomplete text was not getting cleared when Clear the Previous Query on Launch option is enabled.

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed

Info on Pull Request

The issue was happening because the code path for clearing query programmatically didn't set autocomplete text to empty.

Issue1

Validation Steps Performed

Manually validated that autocomplete text is cleared.

@dsrivastavv dsrivastavv added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Aug 28, 2020
@dsrivastavv dsrivastavv requested a review from a team August 28, 2020 21:09
Copy link
Contributor

@ryanbodrug-microsoft ryanbodrug-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsrivastavv dsrivastavv merged commit fe8727b into microsoft:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants