Shift to ControlzEx HC code #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsrivastavv
added
the
Product-PowerToys Run
arjunbalgovind
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Use High-contrast code added in controlzex >= 4.3.1
PR Checklist
Info on Pull Request
ControlzEx took the HC detection logic added in #4007 and added it as part of their theme manager. This PR removes our HC logic and shifts to the one in controlzex.
Note :
System.Windows.ResourceDictionary Warning: 9 : Resource not foundwarning is being thrown on changing theme. This is happening becauseThemeSyncMode.SyncAlltries to find a theme with accent color and if not found, generates a runtime theme. This results in following change sequence : old theme -> runtime theme -> new theme. This warning is not harmful as correct theme is applied at the end of theme change call and powertoys run is hidden during this process.Validation Steps Performed
Manually validated that colors are appropriately changed with change with Light/dark and high contrast themes.