Fixing issues when color picker freezes #8376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Color picker can freeze when you pick a color because we are trying to access clipboard using
Clipboard.SetText
- but this method might as some other applications can hold clipboard.Switching to use
Clipboard.SetDataObject
I couldn't reproduce this issue anymoreThis also fixes another issue when user holds activations keys while picking - this was causing that show picker was called many times and in the end it resulted in a nasty bug where we called copy into clipboard and into the editor nonstop. Can be seen here - https://youtu.be/6mzs90-KlMg?t=195
Described also here #6594
PR Checklist
Info on Pull Request
Validation Steps Performed
Unless you use some special tools for clipboard, it is hard to reproduce as it can happen randomly, but to get a stable reproduction, install Clipjump tool with this running this issue is reproducible all the time and it basically simulate the same issue that can happen randomly with some other application. With the fix, this issue does not appear anymore.
The other issue can be easily reproduced by holding activation keys while picking a color.