-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT Run] Add logs for Launcher #8489
[PT Run] Add logs for Launcher #8489
Conversation
New misspellings found, please review:
To accept these changes, run the following commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I verified that there are new entries in log files.
New misspellings found, please review:
To accept these changes, run the following commands
|
@jsoref |
@@ -294,7 +294,7 @@ class Microsoft_Launcher : public PowertoyModuleIface | |||
{ | |||
if (WaitForSingleObject(m_hProcess, 0) == WAIT_OBJECT_0) | |||
{ | |||
Logger::warn("Launcher exited. Try to restart process."); | |||
Logger::warn("PowerToys Run has exited unexpectedly, restarting PowerToys Run."); | |||
// The process exited, restart it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the logger message already states the same, let's remove this comment.
@mykhailopylyp because it was allowed to land into master (see the comment icon): https://github.com/microsoft/PowerToys/commits/master Someone just needs to run the command the bot suggested and get that merged to master. Sorry. |
Fwiw, I made #8512 which should resolve this. It's just running the script from the bot. |
@mykhailopylyp |
Summary of the Pull Request
What is this about?
Logs should help easily localize
Launcher is not starting
problem.
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?
Check out log files