Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FZ Editor] Move zones + and - buttons to the template layouts flyout #9066

Conversation

SeraphimaZykova
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova commented Jan 12, 2021

Summary of the Pull Request

What is this about:

  • Moved + and - buttons to the template layouts flyout.
  • Possibility to change zone count individually for each template layout.

Untitled

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: [FZ Editor] Fixes for the new Editor UI #8715
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@enricogior enricogior added the FancyZones-Editor Issue revolving the FancyZone Editor label Jan 12, 2021
@htcfreek
Copy link
Collaborator

htcfreek commented Jan 12, 2021

Can we add a description title like "Number of zones" to

  1. have a consistent ux.
  2. describe what the number means.

And I would align the number control left like the others. Imo a normal number control with up/down fits better in the ux.

@enricogior
Copy link
Contributor

@htcfreek
this is work in progress to implement the code behind, the UI is still under design, at this point we don't make any UI change in these PRs

@SeraphimaZykova SeraphimaZykova merged commit 9f34337 into microsoft:users/niels9001/editor-fluent Jan 14, 2021
@SeraphimaZykova SeraphimaZykova deleted the editor/move_template_layout_buttons branch January 14, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FancyZones-Editor Issue revolving the FancyZone Editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants