Fix use of experiment fixture #4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4912 +/- ##
=======================================
Coverage 68.31% 68.31%
=======================================
Files 340 340
Lines 32239 32239
=======================================
Hits 22025 22025
Misses 10214 10214 |
Dominik-Vogel
approved these changes
Jan 9, 2023
|
For reference pytest-dev/pytest#3664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test was missing the fixture causing it to write to the default db
The other tests were incorrectly using mark on fixtures which is not supported. This was partially fixed
by applying the experiment fixture again to the test but that would result in the wrong order
Discovered as part of #4899 and #4906