-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate parameter.__getitem__
#5036
base: main
Are you sure you want to change the base?
Deprecate parameter.__getitem__
#5036
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5036 +/- ##
==========================================
- Coverage 67.31% 67.27% -0.04%
==========================================
Files 357 357
Lines 29839 29841 +2
==========================================
- Hits 20085 20077 -8
- Misses 9754 9764 +10 |
This is not a realistic approach since qcodes_loop makes to heavy use of Suggest to add a class to qcodes loop that takes a parameter as input and exposes |
And therefor the ability to sweep a parameter using the syntax param[0,1.0,10] * This syntax is confusing since its not really indexing the parameter * The implementation requires the input to be floats which is not pytonic * It does nothing that cannot be done with param.sweep
5b7faca
to
028f6b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5036 +/- ##
=======================================
Coverage 69.37% 69.38%
=======================================
Files 341 341
Lines 31381 31385 +4
=======================================
+ Hits 21771 21775 +4
Misses 9610 9610 ☔ View full report in Codecov by Sentry. |
And therefor the ability to sweep a parameter using the syntax
param[0,1.0,10]
pytonic
Perhaps it makes more sense to add a sweep function taking a parameter
and also deprecate sweep.