Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine the code in model description and fix some bugs in feedback.py #288

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

WinstonLiyt
Copy link
Collaborator

@WinstonLiyt WinstonLiyt commented Sep 20, 2024

Description

  • Fixed the error in the feedback, allowing the code to run again.
  • Improved the code logic, especially in how data_description and model_description are used in the feedback.
  • Added the implementation for model_description (initialization and subsequent assignment).
  • Added logic to parse model details such as name, description, formulation, architecture, variables, hyperparameters, and model type.

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

📚 Documentation preview 📚: https://RDAgent--288.org.readthedocs.build/en/288/

@WinstonLiyt WinstonLiyt changed the title fix: fix some bugs in feedback.py feat: refine the code in model description and fix some bugs in feedback.py Sep 20, 2024
@WinstonLiyt WinstonLiyt merged commit 5b124d7 into main Sep 20, 2024
7 checks passed
@WinstonLiyt WinstonLiyt deleted the ytli_fix_bug branch September 20, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants