This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Do not report boxing for optimized value types (#8) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems more appropriate to use the Conversion to check for boxing. Use this for all checks as it is not only applicable when using a value type as argument. Added unit test for the yield return scenario.
Roslyn does not pick up these conversions, so we have to explicitly handle them. Added unit test and changed old tests to account for the change.
|
Fixes some of #8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roslyn does not pick up these conversions, so we have to explicitly handle them.
Added unit test and changed old tests to account for the change.