-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta LWG issue: 2021-06 meeting #1965
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
miscco
added a commit
to miscco/STL
that referenced
this issue
Jun 9, 2021
as this is only internal machinery, I did not add any tests Adresses microsoft#1965
This comment has been minimized.
This comment has been minimized.
miscco
added a commit
to miscco/STL
that referenced
this issue
Jun 9, 2021
We currently have no real infrastructure to test move only iterators, we should discuss that Addresses microsoft#1965
miscco
added a commit
to miscco/STL
that referenced
this issue
Jun 9, 2021
This makes indirectly_readable_traits SFINAE friendly and adds some tests for that Addresses microsoft#1965
miscco
added a commit
to miscco/STL
that referenced
this issue
Jun 9, 2021
I did split out transform_view::iterator tests Addresses microsoft#1965
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 2, 2021
@frederick-vs-ja Thanks for analyzing the remaining issues! I agree with all of your conclusions, and have filed issues accordingly. @MattStephanson I filed #2179, quoting the discussion here, so you can link your PR to it when you're ready. Thanks everyone! All of the June 2021 LWG issues have either been resolved or properly tracked, so I'm closing this meta-issue. |
39 tasks
AreaZR
pushed a commit
to AreaZR/STL
that referenced
this issue
Nov 4, 2021
…microsoft#1991) Addresses microsoft#1965 Co-authored-by: S. B. Tam <cpplearner@outlook.com> Co-authored-by: Casey Carter <Casey@Carter.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(Previous meta-issue: #1679)
At the June 2021 virtual plenary meeting, the following LWG issues were resolved in the C++ Working Paper.
❔ Not yet analyzed
For each of these issues, we've determined whether they are:
✖️ Not applicable
If an issue requires no action from implementers, we mark it as N/A. Categories:
{forward_,}list::unique
qsort
andbsearch
uses_allocator_construction_args
unspecified::std::
" everywhere rule needs tweakingfc.arg()
borrowed_{iterator,subrange}_t
are overspecified😸 Already implemented
Sometimes we cite LWG issues in product code comments as we're implementing their proposed resolutions. When the resolutions are officially accepted, we should remove the citations (as the default assumption is that we're implementing what the Standard says). If something is especially subtle, we can convert the citation to mention the relevant Standard section.
Sometimes we should add test coverage - e.g. when the Standard begins requiring something that we were already doing, but weren't explicitly testing for.
Already implemented, comments need to be removed and messages need to cite the Standard
viewable_range
mishandles lvalue move-only views (Removal in<ranges>
: Remove "per LWG" comments #1967)join_view::
iterator
'siter_swap
is underconstrained (Removal in<ranges>
: Remove "per LWG" comments #1967)iota_view::
sentinel
is not alwaysiota_view
's sentinel (Removal in<ranges>
: Remove "per LWG" comments #1967)BUILTIN-PTR-MEOW
should not opt the type out of syntactic checks (Removal in cleared comment TRANSITION #2186)split_view<V, P>::
inner-iterator
<true>::operator++(int)
should depend onBase
(Removal in<ranges>
: Remove "per LWG" comments #1967)counted_iterator
s refer to the same sequence isn't quite right (Filed as LWG-3543 Definition of whencounted_iterator
s refer to the same sequence isn't quite right #2184)Implemented without comments
lexicographical_compare_three_way
is overspecifiedstd::fstream
& co. should be constructible fromstring_view
(Implemented in<fstream>
: Implement LWG-3430 #1968)priority_queue
(Implemented in Implement P1425 iterator range constructors for stack and queue #1994)noexcept
#2080)InputIterator
template parameter forpriority_queue
constructors (Implemented in Implement P1425 iterator range constructors for stack and queue #1994)uses_allocator_construction_args
handles rvalue pairs of rvalue references incorrectly (Implemented in implement LWG-3527 #2194)make_from_tuple
can perform (the equivalent of) a C-style cast (Implemented in<tuple>
: LWG-3528make_from_tuple
can perform (the equivalent of) a C-style cast #2160)priority_queue(first, last)
should constructc
with(first, last)
base() const &
consistent across iterator wrappers that supportinput_iterator
s (Implemented in Adopt LWG-3533 Makebase() const &
consistent across iterator wrappers that supportinput_iterator
s #1993)chrono::from_stream()
assign zero toduration
for failure? (Implemented in<chrono>
LWG-3536: leave duration unchanged on failed parse #2037)format_to
must not copy models ofoutput_iterator<const charT&>
const
inbasic_format_arg(const T* p)
indirectly_readable_traits
should be SFINAE-friendly for all types (Implemented in Adopt LWG-3541indirectly_readable_traits
should be SFINAE-friendly for all types #1992)basic_format_arg
mis-handlesbasic_string_view
with custom traitsformat-arg-store
::args
is unintentionally not exposition-onlyshared_ptr
construction fromunique_ptr
should move (not copy) the deleter (Implemented in Implement LWG-3548 shared_ptr construction from unique_ptr should move (not copy) the deleter #2007)split_view::
outer-iterator
::value_type::begin()
(Implemented in Adopt LWG-3553 Useless constraint insplit_view::outer-iterator::value_type::begin()
#1990){transform,elements}_view::
iterator
::iterator_concept
should considerconst
-qualification of the underlying range (Implemented in Adopt LWG-3555{transform,elements}_view::iterator::iterator_concept
should considerconst
-qualification of the underlying range #1989)🩹 Patches an unimplemented feature
We should record this LWG issue in the GitHub issue tracking the feature. That way, we'll remember to verify it, but it doesn't represent net new work.
🐞 Not yet implemented
std::function
construction vs assignment (Implemented in LWG-2774std::function
construction vs assignment #2098)common_iterator
'spostfix-proxy
is not quite right (Implemented in Adopt LWG-3546common_iterator
'spostfix-proxy
is not quite right #1991)<random>
classes (Filed as LWG-3519 Incomplete synopses for<random>
classes #2179)iter_move
anditer_swap
are inconsistent fortransform_view::
iterator
(Filed as LWG-3520iter_move
anditer_swap
are inconsistent fortransform_view::iterator
#2180)view_interface
is overspecified to derive fromview_base
(Filed as LWG-3549view_interface
is overspecified to derive fromview_base
#2178)The text was updated successfully, but these errors were encountered: