Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the slide_view constructor precondition added by LWG-3711 #2949

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Check the slide_view constructor precondition added by LWG-3711 #2949

merged 5 commits into from
Sep 13, 2022

Conversation

CaseyCarter
Copy link
Contributor

Towards #2872.

This is "blocked on WP" because I add a citation for a paragraph that doesn't yet exist in the working draft.

@CaseyCarter CaseyCarter added LWG Library Working Group issue ranges C++20/23 ranges blocked on WP Waiting for a new Working Paper labels Jul 27, 2022
@CaseyCarter CaseyCarter requested a review from a team as a code owner July 27, 2022 01:11
CaseyCarter
CaseyCarter commented Jul 27, 2022
View reviewed changes
stl/inc/ranges Outdated Show resolved Hide resolved
StephanTLavavej
StephanTLavavej reviewed Jul 28, 2022
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo nitpick.

tests/std/tests/P2442R1_views_slide_death/test.cpp Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter changed the title Check the slide_view::slide_view precondition added by LWG-3711 Check the slide_view constructor precondition added by LWG-3711 Jul 29, 2022
@StephanTLavavej StephanTLavavej removed the blocked on WP Waiting for a new Working Paper label Sep 6, 2022
@StephanTLavavej
Copy link
Member

I've pushed a conflict-free merge with main, followed by the new WP number. Additionally, I noticed that this was using a strict matrix but would pass with non-strict, so I changed that too (as #3015 was created after this PR).

@StephanTLavavej StephanTLavavej self-assigned this Sep 12, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 82c81e8 into microsoft:main Sep 13, 2022
@StephanTLavavej
Copy link
Member

Thanks for taking care of this LWG issue resolution! ✅ 🎉 😸

CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Oct 6, 2022
@CaseyCarter @StephanTLavavej
Check the slide_view constructor precondition added by LWG-3711 (micr…
668c40e 
…osoft#2949)

Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@CaseyCarter CaseyCarter deleted the lwg-3711 branch August 21, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaseyCarter @StephanTLavavej