Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fstream.seekp(0, ios::cur) #3773

Merged
merged 22 commits into from
Jun 22, 2023
Merged

Fix fstream.seekp(0, ios::cur) #3773

Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f328e63
remove `_Off != 0 || _Way != ios_base::cur`
achabense Jun 15, 2023
273f8ce
formatting
achabense Jun 15, 2023
aefc30a
Create test.cpp
achabense Jun 16, 2023
00d6691
Create env.lst
achabense Jun 16, 2023
2066810
Update test.lst
achabense Jun 16, 2023
d347f17
Merge pull request #1 from achabense/_For_fstream_addcheck
achabense Jun 16, 2023
02668ef
formatting
achabense Jun 16, 2023
d6db4f7
formatting
achabense Jun 16, 2023
bffd1f3
formatting
achabense Jun 16, 2023
373cb4d
Delete env.lst
achabense Jun 16, 2023
92c3546
Delete test.cpp
achabense Jun 16, 2023
0d7890b
Create env.lst
achabense Jun 16, 2023
3aa878c
Add files via upload
achabense Jun 16, 2023
a17f51c
.
achabense Jun 16, 2023
dd89223
..
achabense Jun 16, 2023
a068e86
.
achabense Jun 16, 2023
bdc64a4
.
achabense Jun 16, 2023
5b379da
Delete env.lst
achabense Jun 16, 2023
76966ed
Add files via upload
achabense Jun 16, 2023
2aa3d11
Update env.lst
achabense Jun 16, 2023
d9a8fdf
Code review feedback.
StephanTLavavej Jun 21, 2023
5eb4294
Avoid string_view so the test is C++14
CaseyCarter Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions stl/inc/__msvc_filebuf.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,8 +651,7 @@ class basic_filebuf : public basic_streambuf<_Elem, _Traits> { // stream buffer
_Off -= static_cast<off_type>(sizeof(_Elem)); // back up over _Elem bytes
}

if (!_Myfile || !_Endwrite()
|| ((_Off != 0 || _Way != ios_base::cur) && _CSTD _fseeki64(_Myfile, _Off, _Way) != 0)
if (!_Myfile || !_Endwrite() || _CSTD _fseeki64(_Myfile, _Off, _Way) != 0
|| _CSTD fgetpos(_Myfile, &_Fileposition) != 0) {
return pos_type{off_type{-1}}; // report failure
}
Expand Down