Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary handling in _ReportUnobservedException #3909

Merged
merged 7 commits into from
Aug 1, 2023
Merged

Avoid unnecessary handling in _ReportUnobservedException #3909

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
efbb6e0
`_ReportUnobservedException`: avoid extra handling
AlexGuteniev Jul 28, 2023
6622ec6
Restructure to avoid unreachable code
AlexGuteniev Jul 28, 2023
a59c4b6
format
AlexGuteniev Jul 28, 2023
987f3ab
typo available
AlexGuteniev Jul 28, 2023
13d96db
Casey's review comments
CaseyCarter Jul 28, 2023
5f5ca9e
Remove extra spaces in comments.
StephanTLavavej Jul 28, 2023
b3fd0b0
Invert, always invert.
StephanTLavavej Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions stl/src/ppltasks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,13 @@ namespace Concurrency {

namespace details {
[[noreturn]] _CRTIMP2 void __cdecl _ReportUnobservedException() {

#if (defined(_M_IX86) || defined(_M_X64)) && !defined(_CRT_APP)
if (IsProcessorFeaturePresent(PF_FASTFAIL_AVAILABLE))
#endif
{
__fastfail(FAST_FAIL_INVALID_ARG);
#if (defined(_M_IX86) || defined(_M_X64)) && !defined(_CRT_APP) && _STL_WIN32_WINNT < _WIN32_WINNT_WIN8
if (!IsProcessorFeaturePresent(PF_FASTFAIL_AVAILABLE)) {
std::abort();
}
#endif // ^^^ __fastfail conditionally available ^^^

std::terminate();
__fastfail(FAST_FAIL_INVALID_ARG);
}

namespace platform {
Expand Down