<generator>: Revert unnecessary ADL firewall for _Gen_promise_base
#4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
added
enhancement
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Jul 17, 2024
| } | ||
|
|
||
| #ifndef _M_CEE // TRANSITION, VSO-1659496 |
There was a problem hiding this comment.
No change requested: Technically, this isn't necessary because <generator> is C++23, and /clr is currently limited to C++20. However, following the usual pattern seems fine.
StephanTLavavej
merged commit cf0bf1a
into
microsoft:feature/generator
39 checks passed
|
Thanks! ⚡ 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4464
_Gen_promise_basewas made a nested non-template class of a class template.However, per [basic.lookup.argdep]/3,2, the template arguments of a base class don't furtherly contribute to ADL, so the original implementation strategy should already be ADL-proof for
promise_type.This PR reverts unnecessary changes and adds test cases to ensure that
promise_typeis already ADL-proof. Actually, exsiting unqualified function calls are also doing this.Drive-by change: remove one occurrence of theSuperseded by #4834._NODISCARD_FRIENDworkaround, following up #4782.