Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify optional::swap conditions #5065

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Clarify optional::swap conditions #5065

merged 2 commits into from
Nov 8, 2024

Conversation

KSARK
Copy link
Contributor

@KSARK KSARK commented Nov 4, 2024

resolves #5033

@KSARK KSARK requested a review from a team as a code owner November 4, 2024 15:02
@CaseyCarter CaseyCarter added the documentation Related to documentation or comments label Nov 4, 2024
CaseyCarter
CaseyCarter approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of drive-by edits that I'll apply.

stl/inc/optional Outdated Show resolved Hide resolved
stl/inc/optional Outdated Show resolved Hide resolved
@CaseyCarter
Copy link
Contributor

Thanks! We merge pull requests in batches, so don't expect to see much activity here until later in the week.

@CaseyCarter CaseyCarter mentioned this pull request Nov 4, 2024
Open
@StephanTLavavej StephanTLavavej self-assigned this Nov 7, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 532670b into microsoft:main Nov 8, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for improving these diagnostics, and congratulations on your second microsoft/STL commit! 🥳 😻 🎊

This change is expected to ship in VS 2022 17.13 Preview 3.

@StephanTLavavej StephanTLavavej added enhancement Something can be improved and removed documentation Related to documentation or comments labels Nov 8, 2024
@StephanTLavavej
Copy link
Member

I am going to label and changelog this as enhancement Something can be improved instead of documentation Related to documentation or comments because it affects diagnostics (compiler errors) instead of documentation or code comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange condition in optional::swap
3 participants
@KSARK @CaseyCarter @StephanTLavavej