Implement LWG-4169 std::atomic<T>'s default constructor should be constrained
#5128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, this change shouldn't be conditioned on language mode. |
CaseyCarter
suggested changes
Nov 24, 2024
Also avoid inheriting constructors and additional copy. This reverts commit e682b08.
frederick-vs-ja
commented
Nov 25, 2024
StephanTLavavej
approved these changes
Nov 28, 2024
CaseyCarter
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Not content to leave well enough alone, I've pushed a commit to replace the conditional_t<is_reference_v<_Ty>, _Ty, const _TVal&> parameter type of the _Atomic_storage converting constructors to const _Ty&. They are the same type when _Ty is not an rvalue reference.
These are overkill. The constructors are ill-formed if `_Ty` is an rvalue reference type, and they were ill-formed before the latest change to the parameter types.
StephanTLavavej
approved these changes
Nov 28, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
☢️ 👷 🪄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5123.
Perhaps this should be backported to old modes as we backported WG21-P0883R2.