Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workingset Trimming Report not working #247

Closed
asavioliMSFT opened this issue Aug 11, 2023 · 4 comments
Closed

Workingset Trimming Report not working #247

asavioliMSFT opened this issue Aug 11, 2023 · 4 comments
Assignees
@hacitandogan
Labels
wave 3 - complete consider this issue for next wave of fixes

Comments

@asavioliMSFT
Copy link
Contributor

Every time we try to open this report on Nexus, following errors are occurring:

image

image
@PiJoCoder PiJoCoder added the wave 3 - complete consider this issue for next wave of fixes label Aug 11, 2023
@hacitandogan hacitandogan self-assigned this Sep 1, 2023
@hacitandogan
Copy link
Contributor

Field name "Indicators" does not exists , removing this from DataSet_MemClerks fixing this error as the field is not used in the report.

@PiJoCoder , @asavioliMSFT
Correct fields are ,[IndicatorsProcess] ,[IndicatorsSystem] ,[IndicatorsPool] , should we add those to the grid ?

image

hacitandogan added a commit to hacitandogan/SqlNexus that referenced this issue Sep 1, 2023
@hacitandogan
microsoft#247 Workingset Trimming Report not working
bc37821 
Just removed the field "Indicators"
Should we add [IndicatorsProcess] ,[IndicatorsSystem] ,[IndicatorsPool]  instead ?
@asavioliMSFT
Copy link
Contributor Author

asavioliMSFT commented Sep 1, 2023 •
edited
Loading

Yes. These columns are the most important ones, that will show where the memory pressure is

@PiJoCoder
Copy link
Contributor

Sure, we can add them to the grid. Thanks @hacitandogan!

hacitandogan added a commit to hacitandogan/SqlNexus that referenced this issue Sep 5, 2023
@hacitandogan
microsoft#247 added missing fields.
5fd5c2d 
Added [IndicatorsProcess] ,[IndicatorsSystem] ,[IndicatorsPool] as part of discussion under microsoft#247.
PiJoCoder added a commit that referenced this issue Sep 13, 2023
@PiJoCoder
Merge pull request #252 from hacitandogan/master
28c6265 
Fix #232 (report appears if all tables are there) #247 (fix working set trimming report) and #243 (add CCC rule)
@PiJoCoder
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacitandogan hacitandogan

Labels
wave 3 - complete consider this issue for next wave of fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PiJoCoder @hacitandogan @asavioliMSFT