Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Trace / xEvent Warning for SQL performance impacts #78

Closed
glura opened this issue Apr 5, 2019 · 2 comments
Closed

Improve Trace / xEvent Warning for SQL performance impacts #78

glura opened this issue Apr 5, 2019 · 2 comments
Assignees
Labels
enhancement wave 1 - complete consider this issue for next wave of fixes

Comments

@glura
Copy link

glura commented Apr 5, 2019

I'd like to see an improved or additional warning when potentially expensive traces and/or xEvents are found. I've recently seen a couple of performance cases that likely would have been resolved much sooner if the Active Trace and xEvent report was inspected.
Currently, on the Best Practices & Analysis Summary report, we list an Excessive Trace Warning when multiple trace or xevents collections were detected. BUT, to be honest, this warning is almost always there. It's not uncommon for more than 1 light weight collection to exist or maybe multiple short collections. When the warning is almost always there, people start to ignore it as it doesn't stand out and is often benign.
I'd like to see a "Potentially Expensive" trace warning displayed and be prominent. Maybe even highlight the Active Trace & xEvent Report cell if the warning exists so people at least look at the report. We have the event names that are collected and we know what events are more likely to impact performance than others (ex. statement level events, execution plan events, etc), so we should be able to add some logic with an improved warning about potentially expensive traces. This has potential to find causes or contributors of performance issues that can be easily missed.

@ram2ybabu ram2ybabu self-assigned this Aug 18, 2020
@PiJoCoder
Copy link
Contributor

Pssdiag and SQL LogScout already collect this data and have a column indicating whether an event is expensive or not. We just have to add these in the Best Practices summary report

@PiJoCoder PiJoCoder added enhancement wave 1 - complete consider this issue for next wave of fixes labels Apr 21, 2022
PiJoCoder added a commit that referenced this issue Aug 25, 2022
@PiJoCoder
Copy link
Contributor

Here is a screenshot of what the new rules look like

image

PiJoCoder added a commit that referenced this issue Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement wave 1 - complete consider this issue for next wave of fixes
Projects
None yet
Development

No branches or pull requests

3 participants