Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade github workers to run on latest ubuntu #1603

Closed

Conversation

ppruthi
Copy link
Contributor

@ppruthi ppruthi commented Aug 8, 2022

Related Issues/PRs

GH Announcement: actions/runner-images#6002

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

AB#1918126

@ppruthi ppruthi requested a review from mhamilton723 as a code owner August 8, 2022 10:08
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Hey @ppruthi 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.
We appreciate your patience and contributions 💯!

@ppruthi ppruthi changed the title chore: upgrade github workers onto latest GA version chore: upgrade github workers to run on latest ubuntu Aug 8, 2022
@ppruthi
Copy link
Contributor Author

ppruthi commented Aug 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.00%. Comparing base (93d7ccf) to head (4b51821).
Report is 448 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (93d7ccf) and HEAD (4b51821). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (93d7ccf) HEAD (4b51821)
37 34
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1603      +/-   ##
==========================================
- Coverage   83.76%   75.00%   -8.77%     
==========================================
  Files         292      292              
  Lines       15473    15473              
  Branches      752      752              
==========================================
- Hits        12961    11605    -1356     
- Misses       2512     3868    +1356     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppruthi
Copy link
Contributor Author

ppruthi commented Aug 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ppruthi
Copy link
Contributor Author

ppruthi commented Aug 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ppruthi
Copy link
Contributor Author

ppruthi commented Aug 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ppruthi
Copy link
Contributor Author

ppruthi commented Aug 9, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator

Closing as Serena has added this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants