Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for app execution alias #4696

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harvinders
Copy link

PR checklist

Quick summary of changes
This PR adds support for invoking the app from the command line using the app execution alias by defining it in the appxmanifest file

Which issue does this PR relate to?
#4695

Applies to the following platforms:

  • WinUI
  • WPF
  • UWP

Anything that requires particular review or attention?
No

Do all automated tests pass?
N/A

Have automated tests been added for new features?
N/A

If you've changed the UI:

  • Be sure you are including screenshots to show the changes.
  • Be sure you have reviewed the accessibility checklist.
    N/A

If you've included a new template:

Have you raised issues for any needed follow-on work?
N/A

Have docs been updated?
N/A

If breaking changes or different ways of doing things have been introduced, have they been communicated widely?
N/A

@harvinders harvinders marked this pull request as ready for review June 24, 2023 13:08
@Mysterious-Dev
Copy link
Contributor

Mysterious-Dev commented Jun 24, 2023

If it's a PR that can be merged, personally, I'd see it more as a template alongside the basic one (like self-contained) with mstest as a dependency or as a dependency of mstest

@mrlacey
Copy link
Collaborator

mrlacey commented Jun 26, 2023

Yes, this feel like it should be a separate feature, and not always included (especially without adding to the documentation of this option)

I don't see the connection to the mstest option though? @Mysterious-Dev ?

@Mysterious-Dev
Copy link
Contributor

Mysterious-Dev commented Jun 26, 2023

It is currently not possible to invoke the application from command line. This removes one option to start the application for the user. It also makes it bit tricky to test the application if a tester wants to use the Process class to start the application. Test automation writers have to depend on shell to start the application.

@mrlacey I may have confused automated tests with mstest

@pratikone
Copy link
Collaborator

Yeah, it works best as an option like Self-Contained called maybe "launch from command line". however, you only need it for packaged apps (MSIX packaging option included). Unpackaged apps don't need it because you can directly launch the .exe. So the template option needs to be conscious about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants